Re: [PATCH blktests] tests/srp/rc, tests/nvmeof-mp/rc: add fio check to group_requires

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/7/21 2:14 AM, Bart Van Assche wrote:
On 3/5/21 11:19 PM, Yi Zhang wrote:
Most of the srp and nvmeof-mp tests need fio, we need add fio
check before running the tests

Signed-off-by: Yi Zhang <yi.zhang@xxxxxxxxxx>
---
  tests/nvmeof-mp/rc | 2 +-
  tests/srp/rc       | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/nvmeof-mp/rc b/tests/nvmeof-mp/rc
index ab7770f..4348b16 100755
--- a/tests/nvmeof-mp/rc
+++ b/tests/nvmeof-mp/rc
@@ -42,7 +42,7 @@ and multipathing has been enabled in the nvme_core kernel module"
  	)
  	_have_modules "${required_modules[@]}" || return
- for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof; do
+	for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof fio; do
  		_have_program "$p" || return
  	done
diff --git a/tests/srp/rc b/tests/srp/rc
index 700cd71..2daf199 100755
--- a/tests/srp/rc
+++ b/tests/srp/rc
@@ -59,7 +59,7 @@ group_requires() {
  	)
  	_have_modules "${required_modules[@]}" || return
- for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof sg_reset; do
+	for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof sg_reset fio; do
  		_have_program "$p" || return
  	done
This patch looks good to me but unfortunately it conflicts with my patch
with title "[PATCH blktests v2] rdma: Use rdma link instead of
/sys/class/infiniband/*/parent" ...
Yeah, will send V2 based on yours, thanks.

Bart.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux