Re: [RFC PATCH 04/39] blktrace: add a new global list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Add a separate list to hold running extension traces.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
> ---
>  kernel/trace/blktrace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index ca6f0ceba09b..e45bbfcb5daf 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
>  static LIST_HEAD(running_trace_list);
>  static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
>  
> +static LIST_HEAD(running_trace_ext_list);
> +static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);

Why is this necessary ? This is not explained. Why cannot you keep using
running_trace_lock ?

> +
>  /* Select an alternative, minimalistic output than the original one */
>  #define TRACE_BLK_OPT_CLASSIC	0x1
>  #define TRACE_BLK_OPT_CGROUP	0x2
> 


-- 
Damien Le Moal
Western Digital Research




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux