On 21-02-24 17:32:46, Minwoo Im wrote:
> On 21-02-24 08:26:03, Christoph Hellwig wrote:
> > On Wed, Feb 24, 2021 at 10:52:02AM +0900, Minwoo Im wrote:
> > > On 21-02-23 16:18:22, Christoph Hellwig wrote:
> > > > Historically the BLKRRPART ioctls called into the now defunct ->revalidate
> > > > method, which caused the sd driver to check if any media is present.
> > > > When the ->revalidate method was removed this revalidation was lost,
> > > > leading to lots of I/O errors when using the eject command. Fix this by
> > > > reopening the device to rescan the partitions, and thus calling the
> > > > revalidation logic in the sd driver.
> > >
> > > It looks like a related issue that I've reported in [1]. And this looks
> > > much better!
> >
> > I don't think it fixes the block size issue, does it?
>
> Uh... Sorry for the noise. This reopen is not the first shot so that the
> block size will not be updated because bd_openers is not 0.
> set_init_blocksize is not being invoked.
>
> Sorry please ignore this noise.
FYI,
the block size issue has no issue based on the current tree with
8dc932d3e8af ("Revert "block: simplify set_init_blocksize" to regain
lost performance")
