On 2/22/21 23:10, Christoph Hellwig wrote: > On Tue, Feb 23, 2021 at 03:51:23AM +0000, Chaitanya Kulkarni wrote: >> Looking at the other call sites do we need something like following ? >> Since __blk_queue_bounce() passes the NULL for the passthru case as a >> bio_set value ? > Well, that is a somewhat odd calling convention. What about the patch below > instead? That being we really need to kill this bouncing code off.. I assume you are sending this patch, let me know otherwise. If you do please add, looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>