On 2/7/21 20:42, Ira Weiny wrote: > On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote: >> On 2/7/21 11:04, Chaitanya Kulkarni wrote: >>> Chaitanya Kulkarni (8): >>> brd: use memcpy_from_page() in copy_from_brd() >>> brd: use memcpy_from_page() in copy_from_brd() >> I'm aware that couple of places in brd code we can use memcpy_to_page() >> and get rid the local variable, once I get some feedback I'll add those >> to the V1. > Except for the one comment I had this series look's good to me. > > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > Thanks! > Ira > > Thanks Ira, I'll add your fix in the V1 and send with your review-by tag, when this code is upstream. Thanks a lot for doing this we can get rid of go in null_blk which makes code smooth.