On 2021/02/04 23:55, Jens Axboe wrote:
> On 2/4/21 7:52 AM, Damien Le Moal wrote:
>> On 2021/02/04 23:46, Jens Axboe wrote:
>>> On 2/4/21 1:43 AM, Damien Le Moal wrote:
>>>> Hi Jens,
>>>>
>>>> Instead of spending time fixing the skd driver to (at the very least)
>>>> fix the call to set_capacity() with IRQ disabled, I am proposing to
>>>> simply remove this driver. The STEC S1220 cards are EOL since 2014 and
>>>> not supported by the vendor since several years ago. Given that these
>>>> SSDs are very slow by today's NVMe standard, I do not think it is
>>>> worthwhile to maintain this driver with newer kernel versions. I will
>>>> keep addressing any problem that shows up with LTS versions.
>>>>
>>>> The first patch removes the skd driver and the second patch reverts
>>>> commit 0fe37724f8e7 ("block: fix bd_size_lock use") as the skd driver
>>>> was the one driver that needed this (not so nice) fix.
>>>>
>>>> Please let me know what you think about this.
>>>
>>> I'm fine with removing it. The 5.12 branch doesn't have the later
>>> fix for the bd_size_lock issue, so could you just resend that once
>>> the merge window opens and the block bits have gone in? In case I
>>> forget...
>>
>> OK. Will do.
>>
>> Could you confirm if you received patch #1 ? It looks like the list server is
>> dropping it likely because it is too big.
>
> The list is a huge mess these days, including lore. So not sure what is
> going on. I did receive it, but it wasn't on lore, hence probably only
> because I was CC'ed on it.
Thanks for the confirmation. I will make sure to keep you in cc.
--
Damien Le Moal
Western Digital Research
