On Wed, 2021-02-03 at 03:15 +0000, Chaitanya Kulkarni wrote: > On 2/2/21 18:39, Ming Lei wrote: > > + /* fall through */ > > case REQ_OP_WRITE_ZEROES: > > - return 0; > > I don't think returning 1 for write-zeroes is right, > did you test this patch with write-zeores enabled controller with > the right fs that triggers this behavior ? > > I tested the first iteration of the patch fully mounting an XFS file system with -o discard and creating and deleting files. That was our specific RHEL8 failure we were handling here with David's first submission. I can test his most recent, I have not done that yet. Again, please follow up with exactly what you want based against David's patch and I can test that. Regards Laurence
