On Mon, Feb 01, 2021 at 09:25:42PM -0800, Chaitanya Kulkarni wrote: > Get rid of the wrapper for trace_block_rq_insert() and call the function > directly. The placement of the EXPORT_TRACEPOINT_SYMBOL_GPL looks very strange, I'd keep it with the other EXPORT_TRACEPOINT_SYMBOL_GPL instances in blk-core.c. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>