On 2021/02/02 14:26, Chaitanya Kulkarni wrote:
> blk_fill_rwbs() is an expoted function, add kernel style documentation
> comment.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
> ---
> kernel/trace/blktrace.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 8a2591c7aa41..1a931afcf5c4 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1867,6 +1867,16 @@ void blk_trace_remove_sysfs(struct device *dev)
>
> #ifdef CONFIG_EVENT_TRACING
>
> +/**
> + * blk_fill_rwbs - Fill the buffer rwbs by mapping op to character string.
> + * @rwbs buffer to be filled
> + * @op: REQ_OP_XXX for the tracepoint
> + *
> + * Description:
> + * Maps the REQ_OP_XXX to character and fills the buffer provided by the
> + * caller with resulting string.
> + *
> + **/
> void blk_fill_rwbs(char *rwbs, unsigned int op)
> {
> int i = 0;
>
The description is a little redundant: the short description is enough I think.
But OK.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>
--
Damien Le Moal
Western Digital Research
