Hi, In the current loop driver, there are different coding style present which creates confusion when adding new code e.g. variable declaration, function parameter spacing, switch case break vs return, setting up error code before the error condition when error code is not shared, structure member alignment, inconsistent variable declaration style, declaring the same variable in two switch cases, using extra variable instead of direclty accessing structure member for one occurance in the code etc. This patch-series tries to fix that and also adds some improvements such as adding lockdep assert, reducing the memset count, using snprintf etc. Marking it RFC since I'm sure if these little fixes are welcome or not as code works fine without it. On confirmation I'll spend more time building a patch-series with an an extensive test report. Hopefully unlike my previous series this will not end up twice on the mailing list. -ck Chaitanya Kulkarni (20): loop: use uniform alignment for struct members loop: add lockdep assert in loop_add() loop: add lockdep assert in loop_lookup() loop: allow user to set the queue depth loop: use snprintf for XXX_show() loop: add newline after variable declaration loop: use uniform variable declaration style loop: use uniform function header style loop: remove extra variable in lo_fallocate() loop: remove extra variable in lo_req_flush loop: remove local variable in lo_compat_ioctl loop: cleanup lo_ioctl() loop: remove memset in info64 to compat loop: remove memset in info64 from compat loop: remove memset in loop_info64_from_old() loop: remove memset in loop_info64_to_old() loop: change fd set err at actual error condition loop: configure set err at actual error condition loop: set error value in case of actual error loop: remove the extra line in declaration drivers/block/loop.c | 253 ++++++++++++++++++++----------------------- drivers/block/loop.h | 26 ++--- 2 files changed, 132 insertions(+), 147 deletions(-) -- 2.22.1
