On 1/25/21 10:57 AM, Jens Axboe wrote: > On 1/25/21 10:55 AM, Christoph Hellwig wrote: >> On Mon, Jan 25, 2021 at 10:53:36AM -0700, Jens Axboe wrote: >>> On Sun, Jan 24, 2021 at 3:05 AM Christoph Hellwig <hch@xxxxxx> wrote: >>>> >>>> There is no good reason to reassign ->bi_bdev when remapping the >>>> partition-relative block number to the device wide one, as all the >>>> information required by the drivers comes from the gendisk anyway. >>>> >>>> Keeping the original ->bi_bdev alive will allow to greatly simplify >>>> the partition-away I/O accounting. >>> >>> This one causes boot failures for me on my laptop... >> >> Any output to share? Details of the config? > > .config attached - hard to share any output, as it seems to load the > kernel fine, but latter parts of the boot process end up with errors > after the screen blanks. It's a laptop, so nothing fancy in terms of > logging. FWIW, it did boot on my test box. > > Let me try and do a video... Here you go, complaining about EOD access on partition 6. sudo fdisk -l /dev/nvme0n1 Disk /dev/nvme0n1: 953.89 GiB, 1024209543168 bytes, 2000409264 sectors Disk model: SAMSUNG MZVLB1T0HBLR-000L7 Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: gpt Disk identifier: 51484599-D608-465A-A3A9-D36F1D6D126E Device Start End Sectors Size Type /dev/nvme0n1p1 2048 534527 532480 260M EFI System /dev/nvme0n1p2 534528 567295 32768 16M Microsoft reserved /dev/nvme0n1p3 567296 257560575 256993280 122.6G Microsoft basic data /dev/nvme0n1p4 1998360576 2000408575 2048000 1000M Windows recovery environment /dev/nvme0n1p5 257560576 261718015 4157440 2G Linux filesystem /dev/nvme0n1p6 261718016 390625279 128907264 61.5G Linux filesystem /dev/nvme0n1p7 390625280 421875711 31250432 14.9G Linux swap /dev/nvme0n1p8 421875712 1007812607 585936896 279.4G Linux filesystem /dev/nvme0n1p9 1007812608 1398437887 390625280 186.3G Linux filesystem /dev/nvme0n1p10 1398437888 1593749503 195311616 93.1G Linux filesystem Partition table entries are not in disk order. -- Jens Axboe
Attachment:
142655107_199537265212012_2586972813533745854_n.jpg
Description: JPEG image