Re: [PATCH] bfq: don't duplicate code for different paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Il giorno 25 dic 2020, alle ore 14:00, huhai <huhai@xxxxxxxxxxxxx> ha scritto:
> 
> As we can see, returns parent_sched_may_change whether
> sd->next_in_service changes or not, so remove this judgment.
> 

Thank you very much for spotting this mistake!

Acked-by: Paolo Valente <paolo.valente@xxxxxxxxxx>

> Signed-off-by: huhai <huhai@xxxxxxxxxxxxx>
> ---
> block/bfq-wf2q.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> index 26776bdbdf36..070e34a7feb1 100644
> --- a/block/bfq-wf2q.c
> +++ b/block/bfq-wf2q.c
> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> 
> 	sd->next_in_service = next_in_service;
> 
> -	if (!next_in_service)
> -		return parent_sched_may_change;
> -
> 	return parent_sched_may_change;
> }
> 
> -- 
> 2.20.1
> 
> 
> 





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux