Re: [PATCH blktests] rdma: Use rdma link instead of /sys/class/infiniband/*/parent

[Bart Van Assche <bvanassche@xxxxxxx>]

On 1/20/21 10:58 PM, Yi Zhang wrote:
> On 1/21/21 11:59 AM, Bart Van Assche wrote:
>>   rdma_network_interfaces() {
>> -    (
>> -        cd /sys/class/net &&
>> -            for i in *; do
>> -                [ -e "$i" ] || continue
>> -                # Skip IPoIB (ARPHRD_INFINIBAND) network
>> -                # interfaces.
>> -                [ "$(<"$i"/type)" = 32 ] && continue
>> -                [ -L "$i/device" ] || continue
>> -                d=$(readlink "$i/device" 2>/dev/null)
>> -                if [ -n "$d" ] && is_rdma_device "$i/$d"; then
>> -                    echo "$i"
>> -                fi
>> -            done
>> -    )
>> +    rdma link show | sed -n 's,^link[[:blank:]]*\([^/]*\)/.*,\1,p' |
>> sort -u
>
> We should list the network interface here(like eno1), rxe/siw interfaces
> will not work for function get_ipv4_addr

Thanks for the feedback. I will fix this and repost this patch.

Bart.