On Wed, Jan 13, 2021 at 04:16:51AM +0000, Chaitanya Kulkarni wrote: > We advertise the support for command sets supported in > nvmet_init_cap() -> ctrl->cap = (1ULL << 37). This results in > nvme_enable_ctrl() setting the ctrl->ctrl_config -> NVME_CC_CSS_NVM. > In current code in nvmet_start_ctrl() -> nvmet_cc_css(ctrl->cc) != 0 > checks if value is not = 0 but doesn't use the macro used by the host. > Above function does that also makes it helper that we use in the next > patch where cc_css value is != 0 but NVME_CC_CSS_CSI with > ctrl->cap set to 1ULL << 43. > > With code flow in [1] above function is needed to make sure css value > matches the value set by the host using the same macro in > nvme_enable_ctrl() NVME_CC_CSS_NVM. Otherwise patch looks incomplete > and adding check for the CSS NVM with CSS_CSI looks mixing up things > to me. > > Are you okay with that ? Yeah, we can probably include it in an overall multiple command sets support patch.
