On 1/11/21 23:36, Christoph Hellwig wrote: > I don't see much of a need to share such trivial functionality over > different codebases. > Since there is a function which does exactly same thing thwn why we should open code ? I didn't find a good reason to open code, in fact it made it easier to search for nvmet_bio_done() which is logical point. We can drop this but please consider previous patches as it has a lot of repetitive code. (will remove the weirdness and add name fixes).