Re: [PATCH] bfq: Fix computation of shallow depth

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/5/21 9:21 AM, Jan Kara wrote:
> On Thu 10-12-20 10:44:33, Jan Kara wrote:
>> BFQ computes number of tags it allows to be allocated for each request type
>> based on tag bitmap. However it uses 1 << bitmap.shift as number of
>> available tags which is wrong. 'shift' is just an internal bitmap value
>> containing logarithm of how many bits bitmap uses in each bitmap word.
>> Thus number of tags allowed for some request types can be far to low.
>> Use proper bitmap.depth which has the number of tags instead.
>>
>> Signed-off-by: Jan Kara <jack@xxxxxxx>
> 
> Ping Jens? I think it has fallen through the cracks?

More like waiting for Paolo to take a look. Don't mind taking it, and
I'll do that now, but I do expect him to review any BFQ patches being
sent out.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux