Hi Randy, Thanks for your comments. I will incorporate your comments in my next version. Regards, Muneendra. -----Original Message----- From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxxx] Sent: Saturday, December 19, 2020 10:42 PM To: Muneendra <muneendra.kumar@xxxxxxxxxxxx>; linux-block@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; tj@xxxxxxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx; hare@xxxxxxx Cc: jsmart2021@xxxxxxxxx; emilne@xxxxxxxxxx; mkumar@xxxxxxxxxx; pbonzini@xxxxxxxxxx Subject: Re: [PATCH v5 02/16] blkcg: Added a app identifier support for blkcg On 12/15/20 9:29 PM, Muneendra wrote: Hi-- > --- > block/Kconfig | 9 ++++++ > include/linux/blk-cgroup.h | 56 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 65 insertions(+) > > diff --git a/block/Kconfig b/block/Kconfig index > a2297edfdde8..1920388fb0e9 100644 > --- a/block/Kconfig > +++ b/block/Kconfig > @@ -144,6 +144,15 @@ config BLK_CGROUP_IOLATENCY > > Note, this is an experimental interface and could be changed someday. > > +config BLK_CGROUP_FC_APPID > + bool "Enable support to track FC io Traffic across cgroup applications" > + depends on BLK_CGROUP=y > + help > + Enabling this option enables the support to track FC io traffic across > + cgroup applications.It enables the Fabric and the storage targets to > + identify, monitor, and handle FC traffic based on vm tags by inserting > + application specific identification into the FC frame. Please follow coding-style for Kconfig files: from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
