On Tue, Dec 08, 2020 at 03:21:51PM +0100, Christoph Hellwig wrote: > > + sprintf(cdisk_name, "nvme%dn%dc", ctrl->instance, ns->head->instance); > > And the most important naming decision is this. I have two issues with > naming still: > > - we aready use the c for controller in the hidden disk naming. Although > that is in a different position, but I think this not super intuitive. > - this is missing multipath support entirely, so once we want to add > multipath support we'll run into issues. So maybe use something > based off the hidden node naming? E.g.: > > sprintf(disk_name, "nvme-generic-%dc%dn%d", ctrl->subsys->instance, > ctrl->instance, ns->head->instance); +1 for this naming suggestion.
