Re: [PATCH 2/2] bio: optimise bvec iteration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 24, 2020 at 05:58:13PM +0000, Pavel Begunkov wrote:
> __bio_for_each_bvec(), __bio_for_each_segment() and bio_copy_data_iter()
> fall under conditions of bvec_iter_advance_single(), which is a faster
> and slimmer version of bvec_iter_advance(). Add
> bio_advance_iter_single() and convert them.

Are you sure about bio_advance_iter()?  That API looks like it might
not always be limited to a single segment, and might at least need a
WARN_ON_ONCE to make sure it is not abused.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux