On Tue 24-11-20 14:27:14, Christoph Hellwig wrote: > set_blocksize is used by file systems to use their preferred buffer cache > block size. Block drivers should not set it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > drivers/block/loop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 9a27d4f1c08aac..b42c728620c9e4 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, > size = get_loop_size(lo, file); > loop_set_size(lo, size); > > - set_blocksize(bdev, S_ISBLK(inode->i_mode) ? > - block_size(inode->i_bdev) : PAGE_SIZE); > - > lo->lo_state = Lo_bound; > if (part_shift) > lo->lo_flags |= LO_FLAGS_PARTSCAN; > -- > 2.29.2 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
