Re: [PATCH 3/7] blk-iocost: Just open code the q_name()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tue, Nov 24, 2020 at 11:33:32AM +0800, Baolin Wang wrote:
The simple q_name() function is only called from ioc_name(),
just open code it to make code more readable.

Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

I'm not sure this is an improvement. Either way seems fine to me. So, why
change?

Yes, this may be not called an 'improvement'. Just from my taste of reading code, there is no need to factor out a separate function only including 4 lines code and called by only one place. Anyway I can drop
this patch if you think this is unnecessary. Thanks.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux