On Tue, Nov 24, 2020 at 10:21:23AM +0000, Pavel Begunkov wrote: > Because of how for_each_bvec() works it never advances across multiple > entries at a time, so bvec_iter_advance() is an overkill. Add > specialised bvec_iter_advance_single() that is faster. It also handles > zero-len bvecs, so can kill bvec_iter_skip_zero_bvec(). bvec_iter_advance_single needs a comment describing how it can be used. Also can you take a look at the other callers and see who can be switched over? If you are not sure ask the relevant maintainers.