On Tue, Nov 17, 2020 at 02:07:00PM +0000, Satya Tangirala wrote: > This patch series was tested by running xfstests with test_dummy_encryption > with and without the 'inlinecrypt' mount option, and there were no > meaningful regressions. One regression was for generic/587 on ext4, > but that test isn't compatible with test_dummy_encryption in the first > place, and the test "incorrectly" passes without the 'inlinecrypt' mount > option - a patch will be sent out to exclude that test when > test_dummy_encryption is turned on with ext4 (like the other quota related > tests that use user visible quota files). It would be helpful to have some more testing results that show that the direct I/O support is really working as intended, especially in the new case where logical_block_size < data_unit_size and buffers are only logical_block_size aligned --- both with real hardware and with blk-crypto-fallback. Using my patchset https://lkml.kernel.org/r/20201112194011.103774-1-ebiggers@xxxxxxxxxx it should be possible to test with real eMMC inline encryption hardware on Snapdragon 630; it has logical_block_size=512. Also note, generic/587 was already added to the ext4/encrypt and ext4/encrypt_1k exclusion lists by xfstests-bld commit 02e4bfe628b4. - Eric
