Re: [PATCH v2 8/9] block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>
Subject: Re: [PATCH v2 8/9] block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 16 Nov 2020 18:22:55 +0100
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>, Can Guo <cang@xxxxxxxxxxxxxx>, Stanley Chu <stanley.chu@xxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Martin Kepplinger <martin.kepplinger@xxxxxxx>
In-reply-to: <20201116030459.13963-9-bvanassche@acm.org>
References: <20201116030459.13963-1-bvanassche@acm.org> <20201116030459.13963-9-bvanassche@acm.org>
User-agent: Mutt/1.5.17 (2007-11-01)

On Sun, Nov 15, 2020 at 07:04:58PM -0800, Bart Van Assche wrote:
> Instead of submitting all SCSI commands submitted with scsi_execute() to
> a SCSI device if rpm_status != RPM_ACTIVE, only submit RQF_PM (power
> management requests) if rpm_status != RPM_ACTIVE. Remove flag
> RQF_PREEMPT since it is no longer necessary.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v2 0/9] Rework runtime suspend and SCSI domain validation
  - From: Bart Van Assche
- [PATCH v2 8/9] block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE
  - From: Bart Van Assche

Prev by Date: Re: [PATCH v2 7/9] scsi_transport_spi: Freeze request queues instead of quiescing
Next by Date: Re: [PATCH v2 9/9] block: Do not accept any requests while suspended
Previous by thread: [PATCH v2 8/9] block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE
Next by thread: Re: [PATCH v2 8/9] block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]