On Wed, Nov 11, 2020 at 10:00:44PM +0900, Damien Le Moal wrote: > +#define null_unlock_zone_res(dev, flags) \ > + do { \ > + if ((dev)->need_zone_res_mgmt) \ > + spin_unlock_irqrestore(&(dev)->zone_res_lock, \ > + (flags)); \ > + } while (0) Can you use inline functions here? Otherwise this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>