Re: [PATCH v2 6/9] null_blk: cleanup discard handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 11, 2020 at 02:16:45PM +0900, Damien Le Moal wrote:
>  static inline blk_status_t null_handle_memory_backed(struct nullb_cmd *cmd,
> -						     enum req_opf op)
> +						enum req_opf op, sector_t sector,

This adds an overly long line.

> +	if (op == REQ_OP_DISCARD) {
> +		null_handle_discard(dev, sector, nr_sectors);
> +		return 0;

Maybe add a return value to null_handle_discard to simplify this a bit?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux