On Wed, Nov 11, 2020 at 02:16:45PM +0900, Damien Le Moal wrote: > static inline blk_status_t null_handle_memory_backed(struct nullb_cmd *cmd, > - enum req_opf op) > + enum req_opf op, sector_t sector, This adds an overly long line. > + if (op == REQ_OP_DISCARD) { > + null_handle_discard(dev, sector, nr_sectors); > + return 0; Maybe add a return value to null_handle_discard to simplify this a bit? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>