On Sat, Oct 31, 2020 at 08:58:52AM -0600, Jens Axboe wrote: > On 10/31/20 2:58 AM, Christoph Hellwig wrote: > > -ENOTTY is the convention for "driver does not support this ioctl". > > Use it properly in mtip32xx instead of the bogys -EINVAL. > > While that's certainly true, there is a risk in making a change like this > years after the fact. Not that I expect there are any mtip32xx users > left at this point, but... -ENOTTY is what most drivers return. That being said we can keep the old behavior, so if you prepfer that I can respin to do that.