On Fri, Oct 16, 2020 at 05:14:26PM +0100, Matthew Wilcox (Oracle) wrote: > + err = submit_bio_killable(args.bio, mpage_end_io); > + if (unlikely(err)) > + goto err; > + > + SetPageUptodate(page); On success, isn't the page already set up to date through the mpage_end_io() callback?