Re: [PATCH v2 05/10] s390/dasd: Move duplicate code to separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu,  8 Oct 2020 15:13:31 +0200
Stefan Haberland <sth@xxxxxxxxxxxxx> wrote:

> From: Jan Höppner <hoeppner@xxxxxxxxxxxxx>
> 
> For storing retrieved path information both the if and else block in
> dasd_eckd_read_conf() use the same code. To avoid duplicate code this
> should be done after the if/else block. To further increase readability,
> move the code to a new function, dasd_eckd_store_conf_data().
> 
> Signed-off-by: Jan Höppner <hoeppner@xxxxxxxxxxxxx>
> Reviewed-by: Stefan Haberland <sth@xxxxxxxxxxxxx>
> Signed-off-by: Stefan Haberland <sth@xxxxxxxxxxxxx>
> ---
>  drivers/s390/block/dasd_eckd.c | 42 ++++++++++++++++------------------
>  1 file changed, 20 insertions(+), 22 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux