On 10/6/20 16:51, Logan Gunthorpe wrote: > _have_xfs() does return true/false and can be used with && or in a > conditional. > > Per [1], my opinion is that using && in the requires() function where > the return value is ignored is confusing so I prefer not to do it in new > code. > > If we want to reconsider this we, should add a check to ensure the > return value of requires() matches the expectation of the global > variable it uses. > > Logan > > [1] > https://lore.kernel.org/linux-block/92478e6f-622a-a1ae-6189-4009f9a307bc@xxxxxxxxxxxx/ Make sense to me, lets not change this, thanks for pointing that out.
