Mike, > Like 'io_opt', blk_stack_limits() should stack 'chunk_sectors' using > lcm_not_zero() rather than min_not_zero() -- otherwise the final > 'chunk_sectors' could result in sub-optimal alignment of IO to > component devices in the IO stack. > > Also, if 'chunk_sectors' isn't a multiple of 'physical_block_size' > then it is a bug in the driver and the device should be flagged as > 'misaligned'. Looks good. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering
