On Thu, Sep 03, 2020 at 04:53:34PM -0700, Sagi Grimberg wrote:
> Protect against running tests with the wrong transport type. Most tests
> cannot have nvme_trtype=nvme and discovery tests expect the $trtype to
> be written and verified in the .out file. Adding a couple of helpers
> to restrict the transport types in tests.
>
> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> ---
> tests/nvme/002 | 1 +
> tests/nvme/003 | 1 +
> tests/nvme/004 | 1 +
> tests/nvme/005 | 1 +
> tests/nvme/006 | 1 +
> tests/nvme/007 | 1 +
> tests/nvme/008 | 1 +
> tests/nvme/009 | 1 +
> tests/nvme/010 | 1 +
> tests/nvme/011 | 1 +
> tests/nvme/012 | 1 +
> tests/nvme/013 | 1 +
> tests/nvme/014 | 1 +
> tests/nvme/015 | 1 +
> tests/nvme/016 | 1 +
> tests/nvme/017 | 1 +
> tests/nvme/018 | 1 +
> tests/nvme/019 | 1 +
> tests/nvme/020 | 1 +
> tests/nvme/021 | 1 +
> tests/nvme/022 | 1 +
> tests/nvme/023 | 1 +
> tests/nvme/024 | 1 +
> tests/nvme/025 | 1 +
> tests/nvme/026 | 1 +
> tests/nvme/027 | 1 +
> tests/nvme/028 | 1 +
> tests/nvme/029 | 1 +
> tests/nvme/030 | 1 +
> tests/nvme/031 | 1 +
> tests/nvme/rc | 16 ++++++++++++++++
> 31 files changed, 46 insertions(+)
>
> diff --git a/tests/nvme/002 b/tests/nvme/002
> index 955f68da026a..ca11c11c9a09 100755
> --- a/tests/nvme/002
> +++ b/tests/nvme/002
> @@ -12,6 +12,7 @@ DESCRIPTION="create many subsystems and test discovery"
> requires() {
> _nvme_requires
> _have_modules loop
> + _require_nvme_trtype_is_loop
Same comment here, chain these with &&.
