On 2020-09-03 5:53 p.m., Sagi Grimberg wrote: > We have a collection of nvme tests, but all run with nvme-loop. This > is the easiest to run on a standalone machine. However its very much possible > to run nvme-tcp and nvme-rdma using a loopback network. Add capability to run > tests with a new environment variable to set the transport type $nvme_trtype. > > $ nvme_trtype=[loop|tcp|rdma] ./check nvme > > This buys us some nice coverage on some more transport types. We also add > some transport type specific helpers to mark tests that are relevant only > for a single transport. > > Changes from v6: > - fix _nvme_discover wrong use of subsysnqn that is never passed > - move shellcheck fixes to the correct patches (not fix in subsequent patches) > Changes from v5: > - fix shellcheck errors > Changes from v4: > - removed extra paranthesis > - load either rdma_rxe or siw for rdma transport tests > Changes from v3: > - remove unload_module from tests/srp/rc > - fixed test run cmd > Changes from v2: > - changed patch 6 to move unload_module to common/rc > - changed helper to be named _require_nvme_trtype_is_fabrics > Changes from v1: > - added patch to remove use of module_unload > - move trtype agnostic logig helpers in patch #3 > > Sagi Grimberg (7): > nvme: consolidate nvme requirements based on transport type > nvme: consolidate some nvme-cli utility functions > nvme: make tests transport type agnostic > tests/nvme: restrict tests to specific transports > nvme: support nvme-tcp when runinng tests > common: move module_unload to common > nvme: support rdma transport type Looks good to me. For the whole series: Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> Thanks, Logan
