Re: [PATCH V2 0/2] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 02, 2020 at 11:52:59AM -0600, Jens Axboe wrote:
> On 9/1/20 9:11 PM, Ming Lei wrote:
> > On Tue, Aug 25, 2020 at 10:17:32PM +0800, Ming Lei wrote:
> >> Hi Jens,
> >>
> >> The 1st patch add .mq_quiesce_mutex for serializing quiesce/unquiesce,
> >> and prepares for replacing srcu with percpu_ref.
> >>
> >> The 2nd patch replaces srcu with percpu_ref.
> >>
> >> V2:
> >> 	- add .mq_quiesce_lock
> >> 	- add comment on patch 2 wrt. handling hctx_lock() failure
> >> 	- trivial patch style change
> >>
> >>
> >> Ming Lei (2):
> >>   blk-mq: serialize queue quiesce and unquiesce by mutex
> >>   blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING
> >>
> >>  block/blk-core.c       |   2 +
> >>  block/blk-mq-sysfs.c   |   2 -
> >>  block/blk-mq.c         | 125 +++++++++++++++++++++++------------------
> >>  block/blk-sysfs.c      |   6 +-
> >>  include/linux/blk-mq.h |   7 ---
> >>  include/linux/blkdev.h |   6 ++
> >>  6 files changed, 82 insertions(+), 66 deletions(-)
> >>
> >> Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx>
> >> Cc: Paul E. McKenney <paulmck@xxxxxxxxxx>
> >> Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> >> Cc: Sagi Grimberg <sagi@xxxxxxxxxxx>
> >> Cc: Bart Van Assche <bvanassche@xxxxxxx>
> >> Cc: Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx>
> >> Cc: Chao Leng <lengchao@xxxxxxxxxx>
> >> Cc: Christoph Hellwig <hch@xxxxxx>
> > 
> > Hello Guys,
> > 
> > Is there any objections on the two patches? If not, I'd suggest to move> on.
> 
> Seems like the nested case is one that should either be handled, or at
> least detected.

Yeah, the 1st patch adds mutex for handling nested case correctly and efficiently.

Thanks,
Ming




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux