Re: [PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 2 Sep 2020 15:44:56 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Sagi Grimberg <sagi@xxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>
In-reply-to: <20200902122643.634143-3-ming.lei@redhat.com>
References: <20200902122643.634143-1-ming.lei@redhat.com> <20200902122643.634143-3-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Sep 02, 2020 at 08:26:43PM +0800, Ming Lei wrote:
> The field of 'q_usage_counter' is always fetched in fast path of every
> block driver, and move it into front of 'request_queue', so it can be
> fetched into 1st cacheline of 'request_queue' instance.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH V2 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path
  - From: Ming Lei
- [PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'
  - From: Ming Lei

Prev by Date: Re: [PATCH 02/19] amiflop: use bdev_check_media_change
Next by Date: Re: [PATCH 08/19] xsysace: use bdev_check_media_change
Previous by thread: [PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'
Next by thread: Re: [PATCH V2 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux