Looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx> > +static int floppy_revalidate(struct gendisk *disk); Completely unrelated to this series but, this is the 3rd floppy driver in the series defining it's own floppy_revalidate() and naming it floppy_revalidate(). This makes grepping and reviewing a pain.