Re: [PATCH V2] block: release disk reference in hd_struct_free_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/1/20 4:07 AM, Ming Lei wrote:
> Commit e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal")
> stops to release request queue from wq context because that commit
> supposed all blk_put_queue() is called in context which is allowed
> to sleep. However, this assumption isn't true because we release disk's
> reference in partition's percpu_ref's ->release() which doesn't allow
> to sleep, because the ->release() is run via call_rcu().
> 
> Fixes this issue by moving put disk reference into hd_struct_free_work()

Applied, thanks Ming.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux