On 8/31/20 9:31 AM, Gabriel Krisman Bertazi wrote:
> According to Documentation/block/stat.rst, inflight should not include
> I/O requests that are in the queue but not yet dispatched to the device,
> but blk-mq identifies as inflight any request that has a tag allocated,
> which, for queues without elevator, happens at request allocation time
> and before it is queued in the ctx (default case in blk_mq_submit_bio).
>
> A more precise approach would be to only consider requests with state
> MQ_RQ_IN_FLIGHT.
We've had some churn here, last change in this area was:
commit 6131837b1de66116459ef4413e26fdbc70d066dc
Author: Omar Sandoval <osandov@xxxxxx>
Date: Thu Apr 26 00:21:58 2018 -0700
blk-mq: count allocated but not started requests in iostats inflight
which your patch basically just reverts. So more testing/explanation
needed on why it's necessary.
--
Jens Axboe
