Hi Ming Lei Thanks for your quick comment. As the function request_to_qc_t() in 'include/linux/blk-mq.h ' used the magic '-1', Seems it is hard to replace it with BLK_MQ_NO_TAG :( -----Original Message----- From: Ming Lei [mailto:ming.lei@xxxxxxxxxx] Sent: Wednesday, August 26, 2020 12:29 PM To: tianxianting (RD) <tian.xianting@xxxxxxx> Cc: axboe@xxxxxxxxx; linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] [v2] blk-mq: use BLK_MQ_NO_TAG for no tag On Wed, Aug 26, 2020 at 10:06:51AM +0800, Xianting Tian wrote: > Replace various magic -1 constants for tags with BLK_MQ_NO_TAG. > And move the definition of BLK_MQ_NO_TAG from 'block/blk-mq-tag.h' > to 'include/linux/blk-mq.h' All three symbols are supposed for block core internal code only, so looks you shouldn't move them to public header. Thanks, Ming
