Re: [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 17 Aug 2020 23:00:46 -0400
Cc: Ming Lei <ming.lei@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Coly Li <colyli@xxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Xiao Ni <xni@xxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Evan Green <evgreen@xxxxxxxxxxxx>, Gwendal Grignou <gwendal@xxxxxxxxxxxx>, Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>, Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20200817101718.GC25336@lst.de> (Christoph Hellwig's message of "Mon, 17 Aug 2020 12:17:18 +0200")
Organization: Oracle Corporation
References: <20200817100130.2496059-1-ming.lei@redhat.com> <20200817101718.GC25336@lst.de>

Christoph,

> If you have a few spare cycles, can you kill QUEUE_FLAG_DISCARD and
> just key off discard support based on checking discard_granularity to
> avoid problems like this in the future?

Yes, that would be great!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop
  - From: Ming Lei
- Re: [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop
  - From: Christoph Hellwig

Prev by Date: Re: [RFC PATCH 0/4] block/bpf: add eBPF based block layer IO filtering
Next by Date: Re: [PATCH RESEND 5/5] block: Remove __blk_mq_sched_bio_merge() helper
Previous by thread: Re: [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop
Next by thread: Re: [PATCH RESEND] block: loop: set discard granularity and alignment for block device backed loop
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]