On Mon, Aug 17, 2020 at 08:14:08PM +0800, Baolin Wang wrote: > On Mon, Aug 17, 2020 at 08:32:41AM +0200, Christoph Hellwig wrote: > > On Mon, Aug 17, 2020 at 12:09:19PM +0800, Baolin Wang wrote: > > > The blk_mq_sched_bio_merge() just wrap the __blk_mq_sched_bio_merge(), and > > > no other places will use __blk_mq_sched_bio_merge(). Thus we can combine > > > these 2 similar functions into one function. > > > > I think the idea was to avoid the function call for the nomerges fast > > path. Not sure if that is really worth it. > > Um, no places will use __blk_mq_sched_bio_merge(), not sure if it is a > good choice we still keep an unused and similar function? Well, blk_mq_sched_bio_merge calls __blk_mq_sched_bio_merge, after performing two fast path checks.
