On Mon, Aug 17, 2020 at 05:52:41PM +0800, Ming Lei wrote: > Name of blk_discard_mergable() is very confusing, and this function > actually means if the queue supports multi_range discard. Also there > are two kinds of discard merge: > > 1) multi range discard, bios in one request won't have to be contiguous, > and actually each bio is thought as one range > > 2) single range discard, all bios in one request have to be contiguous > just like normal RW request's merge > > Rename blk_discard_mergable() for not confusing people, and avoiding > to introduce bugs in future. I agree the current name is not good, but I find the new one pretty clumsy too. Not sure the rename is worth it, but also no strict NAK from me.
