Re: [PATCH 13/14] bcache: remove embedded struct cache_sb from struct cache_set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/15/20 6:10 AM, Coly Li wrote:
Since bcache code was merged into mainline kerrnel, each cache set only
as one single cache in it. The multiple caches framework is here but the
code is far from completed. Considering the multiple copies of cached
data can also be stored on e.g. md raid1 devices, it is unnecessary to
support multiple caches in one cache set indeed.

The previous preparation patches fix the dependencies of explicitly
making a cache set only have single cache. Now we don't have to maintain
an embedded partial super block in struct cache_set, the in-memory super
block can be directly referenced from struct cache.

This patch removes the embedded struct cache_sb from struct cache_set,
and fixes all locations where the superb lock was referenced from this
removed super block by referencing the in-memory super block of struct
cache.

Signed-off-by: Coly Li <colyli@xxxxxxx>
---
  drivers/md/bcache/alloc.c     |  6 +++---
  drivers/md/bcache/bcache.h    |  4 +---
  drivers/md/bcache/btree.c     | 17 +++++++++--------
  drivers/md/bcache/btree.h     |  2 +-
  drivers/md/bcache/extents.c   |  6 +++---
  drivers/md/bcache/features.c  |  4 ++--
  drivers/md/bcache/io.c        |  2 +-
  drivers/md/bcache/journal.c   | 11 ++++++-----
  drivers/md/bcache/request.c   |  4 ++--
  drivers/md/bcache/super.c     | 19 +++++++++----------
  drivers/md/bcache/writeback.c |  2 +-
  11 files changed, 38 insertions(+), 39 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@xxxxxxx                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux