On 2020-08-06 12:15, Sagi Grimberg wrote: > There is no need to retry module unload for rdma_rxe > and siw. This also creates a dependency on > tests/nvmeof/rc which prevents it from using in > other test subsystems. If it wouldn't be necessary to retry module unload I wouldn't have introduced a loop. How about moving the unload_module() function definitions from tests/srp/rc and tests/nvmeof-mp/rc into common/rc instead? Thanks, Bart.