Hi Lennart,
Thanks again for the patch, I tested it and it looks good to me. I'll
also add a test case to LTP for this. Two minor nits on the patch:
On Thu, Aug 6, 2020 at 9:32 AM Lennart Poettering <mzxreary@xxxxxxxxxxx> wrote:
> Let's correct that and propagate the flag in LOOP_SETSTATUS too.
Think you meant LOOP_CONFIGURE.
Also, could you add a "Fixes" tag, like:
Fixes: 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl")
>
> Signed-off-by: Lennart Poettering <lennart@xxxxxxxxxxxxxx>
> ---
> drivers/block/loop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index d18160146226..2f137d6ce169 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1171,6 +1171,8 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
> if (part_shift)
> lo->lo_flags |= LO_FLAGS_PARTSCAN;
> partscan = lo->lo_flags & LO_FLAGS_PARTSCAN;
> + if (partscan)
> + lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN;
>
> /* Grab the block_device to prevent its destruction after we
> * put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev).
> --
> 2.26.2
