On 8/6/20 12:15, Sagi Grimberg wrote:
>
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 6ffa971b4308..320aa4b2b475 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -6,6 +6,25 @@
>
> . common/rc
>
> +nvme_trtype=${nvme_trtype:-"loop"}
> +
> +_nvme_requires() {
> + _have_program nvme
> + case ${nvme_trtype} in
> + loop)
> + _have_modules nvmet nvme-core nvme-loop
> + _have_configfs
We should just move nvmet nvme-core configfs _have_nvme_fabrics_common
which are common for all the transports to avoid the duplication.
> + ;;
> + pci)
> + _have_modules nvme nvme-core
> + ;;
> + *)
> + SKIP_REASON="unsupported nvme_trtype=${nvme_trtype}"
> + return 1
> + esac
> + return 0
> +}
> +
> group_requires() {
> _have_root
> }
> -- 2.25.1
Apart from that it looks good to me, I've not tested this yet though.
