Re: [PATCH rfc 6/6] nvme: support rdma transport type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




# nvme_trtype=rdma ./check nvme/030
nvme/030 (ensure the discovery generation counter is updated appropriately)
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
     runtime  0.616s  ...  0.520s 460: unload_module: command not found

The unload_module[1] was defined in [2], how about move the definition to [3],

[1]
_cleanup_nvmet->stop_soft_rdma->unload_module

[2]
./tests/nvmeof-mp/rc

[3]
common/multipath-over-rdma

Right, I had this change locally:
--
diff --git a/common/multipath-over-rdma b/common/multipath-over-rdma
index 676d2837fb06..e54b2a96153c 100644
--- a/common/multipath-over-rdma
+++ b/common/multipath-over-rdma
@@ -457,7 +457,7 @@ stop_soft_rdma() {
                                fi
                        done
        )
-       if ! unload_module rdma_rxe 10; then
+       if ! modprobe -r rdma_rxe; then
                echo "Unloading rdma_rxe failed"
                return 1
        fi
@@ -469,7 +469,7 @@ stop_soft_rdma() {
echo "Failed to unbind the siw driver from ${i%_siw}"
                        done
        )
-       if ! unload_module siw 10; then
+       if ! modprobe -r siw; then
                echo "Unloading siw failed"
                return 1
        fi
--

I'm not at all sure why the retry mechanism that unload_module does
is needed at all...

Bart?



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux