On 03/08/2020 08:49, Sagi Grimberg wrote:
> _create_nvmet_port() {
> local trtype="$1"
> + local traddr="${2:-$def_traddr}"
> + local adrfam="${3:-$def_adrfam}"
> + local trsvcid="${4:-$def_trsvcid}"
>
> local port
> for ((port = 0; ; port++)); do
> @@ -109,6 +152,9 @@ _create_nvmet_port() {
>
> mkdir "${NVMET_CFS}/ports/${port}"
> echo "${trtype}" > "${NVMET_CFS}/ports/${port}/addr_trtype"
> + echo "${traddr}" > "${NVMET_CFS}/ports/${port}/addr_traddr"
> + echo "${adrfam}" > "${NVMET_CFS}/ports/${port}/addr_adrfam"
> + echo "${trsvcid}" > "${NVMET_CFS}/ports/${port}/addr_trsvcid"
>
> echo "${port}"
These look like they should belong into another patch. Probably
"[PATCH rfc 3/6] nvme: make tests transport type agnostic"
Otherwise looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
