On 7/28/20 5:19 PM, Peilin Ye wrote: > raw_cmd_copyout() is potentially copying uninitialized kernel stack memory > since it is initializing `cmd` by assignment, which may cause the compiler > to leave uninitialized holes in this structure. Fix it by using memcpy() > instead. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 2145e15e0557 ("floppy: don't write kernel-only members to FDRAWCMD ioctl output") Nitpick, I would say this fix is not related to commit 2145e15e0557. > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx> > Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>