On 7/28/20 10:05 AM, Daniel Wagner wrote: > No need to define typedefs for the callbacks, because there is not a > single user except blk_mq_ops. Concept looks fine to me, but you're mixing indentations a bit. Just remove the indentation bits, we don't need them here. -- Jens Axboe